Re: doc: improve PG 12 to_timestamp()/to_date() wording - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: doc: improve PG 12 to_timestamp()/to_date() wording
Date
Msg-id 20190501001403.GN3925@telsasoft.com
Whole thread Raw
In response to Re: doc: improve PG 12 to_timestamp()/to_date() wording  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: doc: improve PG 12 to_timestamp()/to_date() wording  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote:
> I'd like to add couple of comments from my side.

> > -       returns an error because the second template string space is consumed
> > -       by the letter <literal>J</literal> in the input string.
> > +       returns an error because the second space in the template string consumes
> > +       the letter <literal>M</literal> from the input string.
> 
> Why <literal>M</literal>?  There is no letter "M" is input string.
> The issue here is that we already consumed "J" from "JUN" and trying
> to match "UN" to "MON".  So, I think we should live
> <literal>J</literal> here.  The rest of this change looks good.

Seems like I confused myself while resolving rebase conflict.

Thanks for checking.

Justin



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: clean up docs for v12
Next
From: Melanie Plageman
Date:
Subject: Adding a test for speculative insert abort case