On Sun, Apr 28, 2019 at 07:26:55PM +0200, Fabien COELHO wrote:
>
> Hello David,
>
> > > Patch applies. There seems to be a compilation issue:
> > >
> > > describe.c:5974:1: error: expected declaration or statement at end of
> > > input
> > > }
> >
> > This is in brown paper bag territory. Fixed.
>
> I do not understand why you move both size and description out of the
> verbose mode, it should be there only when under verbose?
My mistake. Fixed.
> > I've sent a separate patch extracted from the one you sent which adds
> > stdin to our TAP testing infrastructure. I hope it lands so it'll be
> > simpler to add these tests in a future version of the patch.
>
> Why not. As I'm the one who wrote the modified function, probably I could
> have thought of providing an input. I'm not sure it is worth a dedicated
> submission, could go together with any commit that would use it.
My hope is that this is seen as a bug fix and gets back-patched.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
