Re: pg_waldump and PREPARE - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_waldump and PREPARE
Date
Msg-id 20190425190836.GA6844@alvherre.pgsql
Whole thread Raw
In response to Re: pg_waldump and PREPARE  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: pg_waldump and PREPARE
List pgsql-hackers
On 2019-Apr-26, Fujii Masao wrote:

> On Fri, Apr 26, 2019 at 1:04 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> >  I also wonder if
> > defining the structs in the way you do is the most sensible arrangement.
> 
> I did that arrangement because the format of PREPARE TRANSACTION record,
> i.e., that struct, also needs to be accessed in backend and frontend.
> But, of course, if there is smarter way, I'm happy to adopt that!

I don't know.  I spent some time staring at the code involved, and it
seems it'd be possible to improve just a little bit on cleanliness
grounds, with a lot of effort, but not enough practical value.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Segfault when restoring -Fd dump on current HEAD
Next
From: Tom Lane
Date:
Subject: Re: jsonpath