Re: [Patch] Check file type before calling AllocateFile() for filesout of pg data directory to avoid potential issues (e.g. hang). - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [Patch] Check file type before calling AllocateFile() for filesout of pg data directory to avoid potential issues (e.g. hang).
Date
Msg-id 20190425002052.GC8552@paquier.xyz
Whole thread Raw
In response to Re: [Patch] Check file type before calling AllocateFile() for files out of pg data directory to avoid potential issues (e.g. hang).  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Apr 24, 2019 at 10:36:03AM -0400, Tom Lane wrote:
> Nah, I don't buy that one either.  Nobody has any business creating any
> non-Postgres files in the stats directory ... and if somebody does want
> to stick a FIFO in there, perhaps for debug purposes, why should we stop
> them?

I have never used a FIFO in Postgres for debugging purposes, but that
sounds plausible.  I am not sure either the changes proposed in the
patch are a good idea.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Why is it OK for dbsize.c to look at relation files directly?
Next
From: Michael Paquier
Date:
Subject: Re: Why is it OK for dbsize.c to look at relation files directly?