Re: Why is it OK for dbsize.c to look at relation files directly? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Why is it OK for dbsize.c to look at relation files directly?
Date
Msg-id 20190425001650.GB8552@paquier.xyz
Whole thread Raw
In response to Why is it OK for dbsize.c to look at relation files directly?  (Andres Freund <andres@anarazel.de>)
Responses Re: Why is it OK for dbsize.c to look at relation files directly?
List pgsql-hackers
On Wed, Apr 24, 2019 at 04:09:56PM -0700, Andres Freund wrote:
> I think we should change dbsize.c to call
> RelationGetNumberOfBlocksInFork() for relkinds != TABLE/TOAST/MATVIEW,
> and a new AM callback for those. Probably with the aforementioned
> additional logic of closing smgr references if they weren't open before
> the size computation.
>
> Imo this pretty clearly is v13 work.

Agreed that this is out of 12's scope.  Perhaps you should add a TODO
item for that?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Why is it OK for dbsize.c to look at relation files directly?
Next
From: Andres Freund
Date:
Subject: Re: Why is it OK for dbsize.c to look at relation files directly?