Postgres Pro
Downloads
Home   >   mailing lists

Re: [Patch] Check file type before calling AllocateFile() for filesout of pg data directory to avoid potential issues (e.g. hang). - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [Patch] Check file type before calling AllocateFile() for filesout of pg data directory to avoid potential issues (e.g. hang).
Date
Msg-id 20190424125413.GA27406@alvherre.pgsql
Whole thread Raw
In response to Re: [Patch] Check file type before calling AllocateFile() for filesout of pg data directory to avoid potential issues (e.g. hang).  (Paul Guo <pguo@pivotal.io>)
Responses Re: [Patch] Check file type before calling AllocateFile() for files out of pg data directory to avoid potential issues (e.g. hang).
List pgsql-hackers
Tree view 
On 2019-Apr-24, Paul Guo wrote:

> On Wed, Apr 24, 2019 at 12:49 PM Andres Freund <andres@anarazel.de> wrote:

> > This seems like a bad idea to me. IMO we want to support using a pipe
> > etc here. If the admin creates a fifo like this without attaching a
> > program it seems like it's their fault.
> 
> Oh, I never know this application scenario before. So yes, for this, we
> need to keep the current code logic in copy code.

But the pgstat.c patch seems reasonable to me.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Optimizer items in the release notes
Next
From: Robert Haas
Date:
Subject: Re: finding changed blocks using WAL scanning