On 2019-Apr-12, Michael Paquier wrote:
> On Fri, Apr 12, 2019 at 12:33:45PM +0900, Fujii Masao wrote:
> > Indeed. Attached is the updated version of the patch.
>
> On top of what Alvaro has mentioned, it seems to me that we should
> make the difference between table-level configuration parameter and
> index-level configuration parameters, and also add <primary> markups
> to create_index.sgml. If you take the example of fillfactor, it
> applies to both indexes and tables, but with your patch you just
> define "configuration parameter", and point to only CREATE TABLE.
Are you suggesting that it should show "index storage parameters" and
"table storage parameters"? I'm not sure about that myself ...
particularly considering that certain parameters might apply to some
index AMs and not others.
BTW what about the index-specific options such as, say, BRIN's
pages_per_range? I know other AMs have their own reloptions ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
