Re: pgsql: Fix memory leak in pgbench - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Fix memory leak in pgbench
Date
Msg-id 20190411155225.7kokoz2agq6lbwwr@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Fix memory leak in pgbench  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix memory leak in pgbench  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-committers
Hi,

On 2019-04-11 09:35:23 -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > On Thu, Apr 11, 2019 at 09:03:19AM +0200, Fabien COELHO wrote:
> >> I can set up farm animals with bleeding age clang/gcc (compiled weekly from
> >> sources) with -Werror (seawasp & moonjelly are already running with those
> >> but without -Werror).
> 
> > If possible, I would not recommend using compiled versions from
> > source, but just the latest stable versions released for gcc and 
> > clang.  Even if this can catch up compiler bugs using Postgres code at
> > a very early stage, the false positives induced have been proving to
> > hurt because of the time investigations took to determine if this was
> > a problem on our side or not.
> 
> Yeah, I'm not excited about having to expend effort on working around
> warnings seen only in unstable compilers.  I was thinking more of
> using some solid-but-not-ancient gcc release.

I could easily add that to one of EXEC_BACKEND or -DDCOPY_PARSE_PLAN_TREES
-DRAW_EXPRESSION_COVERAGE_TEST, --disable-atomics, --disable-spinlocks
animals. I'd probably go for one of the latter, because they tend to
break very rarely for other reasons these days.

While the buildfarm page says they run gcc 6, it's actually just the
latest stable release, updated regularly.

I kinda wish the buildfarm wouldn't require manually updating compiler
versions...

Greetings,

Andres Freund



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix memory leak in pgbench
Next
From: Fabien COELHO
Date:
Subject: Re: pgsql: Fix memory leak in pgbench