On 2019-Mar-29, Jesper Pedersen wrote:
> I ran my test cases for this feature, and havn't seen any issues.
>
> Therefore I'm marking 1877 as Ready for Committer. If others have additional
> feedback feel free to switch it back.
Thanks!
I found two issues today. One, server side, is that during cloning for
partition attach we were not checking for concurrent deletion of
referenced tuples in partitions. I added an isolation spec test for
this. To fix the bug, added a find_all_inheritors() to lock all
partitions with ShareRowExclusiveLock.
Another is that psql's \d failed for versions < 12, because we were
inconditionally adding an "AND conparentid = 0" clause.
I also reworked CloneForeignKeyConstraints. The previous style was
being forced by the old recursing method; now we can make it a lot
simpler -- it's now just two subroutine calls.
I'm satisfied with this patch now, so I intend to push early tomorrow.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
