Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru
Date
Msg-id 20190330010822.GL1954@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru
List pgsql-hackers
On Fri, Mar 29, 2019 at 11:22:55AM -0300, Alvaro Herrera wrote:
> Yeah, that looks good to me too.  I wonder if we really need it as LOG
> though; we don't say anything for actions unless they take more than the
> min duration, so why say something for a no-op that takes almost no time?
> Maybe make it DEBUG1.

I think that this does not justify a WARNING, as that's harmless for
the user even if we use WARNING for other skips (see
vacuum_is_relation_owner).  However DEBUG1 is also too low in my
opinion as this log can be used as an indicator that autovacuum is too
much aggressive because there are too many workers for example.  I
have seen that matter in some CPU-bound environments.  I won't fight
hard if the consensus is to use DEBUG1 though.  So, more opinions?
Andrew perhaps?

> s/relfroxzenxid/relfrozenxid/

Sure.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Unix socket dir, an idea
Next
From: Michael Paquier
Date:
Subject: Re: REINDEX CONCURRENTLY 2.0