Re: compiler warning in pgcrypto imath.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: compiler warning in pgcrypto imath.c
Date
Msg-id 20190323012016.GG20584@paquier.xyz
Whole thread Raw
In response to compiler warning in pgcrypto imath.c  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: compiler warning in pgcrypto imath.c
List pgsql-hackers
On Fri, Mar 22, 2019 at 08:20:53PM -0400, Jeff Janes wrote:
> PostgreSQL 12devel on aarch64-unknown-linux-gnu, compiled by gcc
> (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0, 64-bit

Adding Noah in CC as he has done the update of imath lately.

> The attached patch adds PG_USED_FOR_ASSERTS_ONLY to silence it.  Perhaps
> there is a better way, given that we want to change imath.c as little as
> possible from its upstream?

Maybe others have better ideas, but marking the variable with
PG_USED_FOR_ASSERTS_ONLY as you propose seems like the least invasive
method of all.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: compiler warning in pgcrypto imath.c
Next
From: Michael Paquier
Date:
Subject: Re: Introduce MIN/MAX aggregate functions to pg_lsn