Re: Fwd: Add tablespace tap test to pg_rewind - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fwd: Add tablespace tap test to pg_rewind
Date
Msg-id 20190322053438.GV20192@paquier.xyz
Whole thread Raw
In response to Re: Fwd: Add tablespace tap test to pg_rewind  (Shaoqi Bai <sbai@pivotal.io>)
Responses Re: Fwd: Add tablespace tap test to pg_rewind
List pgsql-hackers
On Thu, Mar 21, 2019 at 11:41:01PM +0800, Shaoqi Bai wrote:
> Have updated the patch doing as you suggested

+   RewindTest::setup_cluster($test_mode, ['-g']);
+   RewindTest::start_master();

There is no need to test for group permissions here, 002_databases.pl
already looks after that.

+   # Check for symlink -- needed only on source dir, only allow symlink
+   # when under pg_tblspc
+   # (note: this will fall through quietly if file is already gone)
+   if (-l $srcpath)
So you need that but in RecursiveCopy.pm because of init_from_backup
when creating the standby, which makes sense when it comes to
pg_tblspc.  I am wondering about any side effects though, and if it
would make sense to just remove the restriction for symlinks in
_copypath_recurse().
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: "Yuzuko Hosoya"
Date:
Subject: RE: Problem with default partition pruning