Hi Jesper
On 2019-Mar-01, Jesper Pedersen wrote:
> I'm getting a failure in the pg_upgrade test:
>
> --
> +-- Name: pk5 pk5_pkey; Type: CONSTRAINT; Schema: regress_fk; Owner:
> jpedersen
> +--
> +
> +ALTER TABLE ONLY regress_fk.pk5
> + ADD CONSTRAINT pk5_pkey PRIMARY KEY (a);
> +
> +
> +--
>
> when running check-world.
So I tested this case just now (after fixing a couple of bugs) and see a
slightly different problem now: those excess lines are actually just
that pg_dump chose to print the constraints in different order, as there
are identical lines with "-" in the diff I get. The databases actually
*are* identical as far as I can tell. I haven't yet figured out how to
fix this; of course, the easiest solution is to just drop the regress_fk
schema at the end of the foreign_key.sql regression test, but I would
prefer a different solution.
I'm going to post the new version of the patch separately.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
