Re: pg_dump multi VALUES INSERT - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_dump multi VALUES INSERT
Date
Msg-id 20190304154625.GA495@alvherre.pgsql
Whole thread Raw
In response to Re: pg_dump multi VALUES INSERT  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On 2019-Mar-02, Fabien COELHO wrote:

> Although I'm all in favor of checking the int associated to the option, I do
> not think that it warrants three checks and messages. I would suggest to
> factor them all as just one check and one (terse) message.

I suggest ("rows-per-insert must be in range 1..%d", INT_MAX), like
extra_float_digits and compression level.

> About the output: I'd suggest to indent one line per row, something like:
> 
>   INSERT INTO foo VALUES
>     (..., ..., ..., ...),
>     (..., ..., ..., ...),
>     (..., ..., ..., ...);

+1.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: "Daniel Verite"
Date:
Subject: Re: insensitive collations
Next
From: Magnus Hagander
Date:
Subject: Re: Online verification of checksums