Re: get_controlfile() can leak fds in the backend - Mailing list pgsql-hackers

From Andres Freund
Subject Re: get_controlfile() can leak fds in the backend
Date
Msg-id 20190227093231.ermj4gurayhxiyyo@alap3.anarazel.de
Whole thread Raw
In response to Re: get_controlfile() can leak fds in the backend  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: get_controlfile() can leak fds in the backend
List pgsql-hackers
Hi,

On 2019-02-27 10:23:45 +0100, Fabien COELHO wrote:
> However, while at it, there is also the question of whether the control file
> should be locked when updated, eg with flock(2) to avoid race conditions
> between concurrent commands. ISTM that there is currently not such thing in
> the code, but that it would be desirable.

Shouldn't be necessary - the control file fits into a single page, and
writes of that size ought to always be atomic. And I also think
introducing flock usage for this would be quite disproportional.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: get_controlfile() can leak fds in the backend
Next
From: Dmitry Dolgov
Date:
Subject: Re: Segfault when restoring -Fd dump on current HEAD