Re: TupleTableSlot abstraction - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TupleTableSlot abstraction
Date
Msg-id 20190227052152.GA3540@paquier.xyz
Whole thread Raw
In response to Re: TupleTableSlot abstraction  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: TupleTableSlot abstraction  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Sat, Feb 16, 2019 at 05:07:44PM -0500, Jeff Janes wrote:
> By blind analogy to the changes made to matview.c, I think that createas.c
> is missing a heap_freetuple, as attached.

I think that you are right.  CTAS and materialized views share a lot
when it comes to relation creation and initial table loading.  I have
reproduced the leak and could notice that your fix is correct.  So
committed.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: pgsql: Avoid creation of the free space map for small heaprelations, t
Next
From: "Ideriha, Takeshi"
Date:
Subject: RE: Protect syscache from bloating with negative cache entries