Re: Progress reporting for pg_verify_checksums - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Progress reporting for pg_verify_checksums
Date
Msg-id 20190218164237.GA7617@alvherre.pgsql
Whole thread Raw
In response to Re: Progress reporting for pg_verify_checksums  (Bernd Helmle <mailings@oopsware.de>)
Responses Re: Progress reporting for pg_verify_checksums  (Michael Banck <michael.banck@credativ.de>)
List pgsql-hackers
On 2019-Feb-18, Bernd Helmle wrote:

> Am Montag, den 18.02.2019, 16:52 +0100 schrieb Michael Banck:
> > > Surely we know at that point whether this first scan is needed, and
> > we
> > > can skip it if not?
> > 
> > Yeah - new patch attached.
> 
> Maybe i'm wrong, but my thought is that this breaks the SIGUSR1
> business, since there seems no code path which calculates total_size in
> this case?

Oh, yeah, it does.  In that case, a comment explaining that is needed.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
Next
From: Michael Banck
Date:
Subject: Re: Progress reporting for pg_verify_checksums