Re: [Patch] checksumming-related buglets inpg_verify_checksums/pg_basebackup TAP tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [Patch] checksumming-related buglets inpg_verify_checksums/pg_basebackup TAP tests
Date
Msg-id 20190218052503.GL15532@paquier.xyz
Whole thread Raw
In response to [Patch] checksumming-related buglets inpg_verify_checksums/pg_basebackup TAP tests  (Michael Banck <michael.banck@credativ.de>)
List pgsql-hackers
On Thu, Feb 14, 2019 at 03:07:56PM +0100, Michael Banck wrote:
> This also revealed a second bug in the pg_basebackup test suite where
> the offset for the corruption in the second file was wrong, so it
> actually never got corrupted, and the tests only passed due to the above
> twice than expected number of written bytes. The write() probably
> overflowed into an adjacent block so that the total number of corrupted
> blocks was as expected by accident. Oops, my bad, patch attached.

Fixed and back-patched where adapted, thanks!  ee9e145 was a first
shot for a fix in pg_basebackup tests, but it has missed one seek()
call.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: 2019-03 CF Summary / Review - Tranche #2
Next
From: "Kuroda, Hayato"
Date:
Subject: RE: Prevent extension creation in temporary schemas