Re: REL_11_STABLE: dsm.c - cannot unpin a segment that is not pinned - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: REL_11_STABLE: dsm.c - cannot unpin a segment that is not pinned
Date
Msg-id 20190217223637.GF28750@telsasoft.com
Whole thread Raw
In response to Re: REL_11_STABLE: dsm.c - cannot unpin a segment that is not pinned  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
On Mon, Feb 18, 2019 at 09:26:53AM +1300, Thomas Munro wrote:
> Huh.  What exactly do you mean by "killing the postmaster"?  If you
> mean SIGKILL or something, one problem with 11 is that
> gather_readnext() doesn't respond to postmaster death.  I fixed that
> (and every similar place) in master with commit cfdf4dc4fc9, like so:

On Mon, Feb 18, 2019 at 10:26:12AM +1300, Thomas Munro wrote:
> Yeah.  I suppose we should probably consider back-patching a fix for that.

It hasn't been an issue for us, but that seems like a restart hazard.  Who
knows what all the distros initscripts do, how thin a layer they are around
pg_ctl or kill, but you risk waiting indefinitely for postmaster and its gather
backend/s to die, all the while rejecting new clients with 'the database system
is shutting down'.

+1

Justin


pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Ryu floating point output patch
Next
From: Peter Geoghegan
Date:
Subject: Re: CPU costs of random_zipfian in pgbench