Re: BUG #15631: Generated as identity field in a temporary tablewith on commit drop corrupts system catalogs - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15631: Generated as identity field in a temporary tablewith on commit drop corrupts system catalogs
Date
Msg-id 20190213023817.GD5746@paquier.xyz
Whole thread Raw
In response to Re: BUG #15631: Generated as identity field in a temporary table with on commit drop corrupts system catalogs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #15631: Generated as identity field in a temporary tablewith on commit drop corrupts system catalogs  (Michael Paquier <michael@paquier.xyz>)
List pgsql-bugs
On Tue, Feb 12, 2019 at 09:27:50AM -0500, Tom Lane wrote:
> Hm, I'd be more inclined to find where the sequence creation is happening
> and add a CCI at the end, because that comports better with the general
> plan for inserting CCIs.  There may be other issues of this same sort with
> doing-X-just-after-identity-sequence-creation if you don't fix it that
> way.

Agreed.  I don't think that it is the correct logic to put an
after-the-fact CCI just before executing any drop or truncate actions.
It should happen after the creation of the new object so as it becomes
correctly visible within the transaction.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: "Saul, Jean Paolo"
Date:
Subject: Re: BUG #15609: synchronous_commit=off insert performance regressionwith secondary indexes
Next
From: Amit Langote
Date:
Subject: Re: BUG #15623: Inconsistent use of default for updatable view