Re: pgsql: Use Getopt::Long for catalog scripts - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Use Getopt::Long for catalog scripts
Date
Msg-id 20190212213225.GA11073@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Use Getopt::Long for catalog scripts  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-committers
On 2019-Feb-13, Thomas Munro wrote:

> whelk, woodlouse and dory say:
> 
> Generating src/interfaces/ecpg/pgtypeslib/pgtypeslib.def...
> Unknown option: i../../../src/include/
> Usage: perl -I [directory of Catalog.pm] Gen_fmgrtab.pl
> [--include-path/-i <path>] [path to pg_proc.dat]
> 
> Options:
>     --output         Output directory (default '.')
>     --include-path   Include path in source tree
> 
> Does Solution.pm need to be tweaked?

So Getopt::Long does not like the missing ' ' or '=', eh?
I pushed an untested fix, let's see if that's it.  Thanks for the poke.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Blind attempt at fixing Windows build
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Relax overly strict assertion