Re: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm
Date
Msg-id 20190207014458.GE4074@paquier.xyz
Whole thread Raw
In response to Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
On Wed, Feb 06, 2019 at 08:34:11PM -0500, Andrew Dunstan wrote:
> The obvious solution is to perform the same surgery for the ssl and
> pg_rewind tests that we performed for genbki.pl and other scripts, but
> in these cases the used modules are not in the same directory as the
> using scripts, but in their parent directories. I can't think of a good
> reason for this.They clearly relate to the TAP test suites, and nothing
> else, so it seems to me that they should go into the same directory as
> the TAP test scripts. There should be no danger that "prove" will try to
> run them, as it is only set up to run files with a ".pl" extension.
>
> While we're at it, I think ServerSetup.pm should possibly be renamed to
> something like SSLServer.pm (and the perl code adjusted accordingly)
>
> Does anyone object to me making these changes?

Not really if this eases the buildfarm coverage.  At the same time, it
seems to me that it could be a good idea to install those sub-modules.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm
Next
From: Justin Pryzby
Date:
Subject: Re: pg11.1: dsa_area could not attach to segment