Postgres Pro
Downloads
Home   >   mailing lists

Re: Tighten up a few overly lax regexes in pg_dump's tap tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Tighten up a few overly lax regexes in pg_dump's tap tests
Date
Msg-id 20190207011032.GC4074@paquier.xyz
Whole thread Raw
In response to Re: Tighten up a few overly lax regexes in pg_dump's tap tests  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Tighten up a few overly lax regexes in pg_dump's tap tests  ("Tels" <nospam-pg-abuse@bloodgate.com>)
Re: Tighten up a few overly lax regexes in pg_dump's tap tests  (David Fetter <david@fetter.org>)
List pgsql-hackers
Tree view 
On Wed, Feb 06, 2019 at 03:41:20PM +0100, Daniel Gustafsson wrote:
> Correct.  One could argue that the regex is still suboptimal since “COMMENT ON
> DATABASE postgres IS  ;” will be matched as well, but there I think the tradeoff
> for readability wins.

Okay, that looks like an improvement anyway, so committed after going
over the tests for similar problems, and there was one for CREATE
DATABASE and DROP ROLE.  It is possible to have a regex which tells as
at least one non-whitespace character, but from what I can see these
don't really improve the readability.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Commit Fest 2019-01 is now closed
Next
From: Michael Paquier
Date:
Subject: Re: Add missing CREATE TABLE IF NOT EXISTS table_name AS EXECUTEquery;