Re: Too rigorous assert in reorderbuffer.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Too rigorous assert in reorderbuffer.c
Date
Msg-id 20190206163050.GA22952@alvherre.pgsql
Whole thread Raw
In response to Re: Too rigorous assert in reorderbuffer.c  (Arseny Sher <a.sher@postgrespro.ru>)
Responses Re: Too rigorous assert in reorderbuffer.c  (Arseny Sher <a.sher@postgrespro.ru>)
List pgsql-hackers
On 2019-Feb-06, Arseny Sher wrote:

> 
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> 
> > note the additional pg_temp_XYZ row in the middle.  This is caused by
> > the rewrite in ALTER TABLE.  Peter E fixed that in Pg11 in commit
> > 325f2ec55; I don't think there's much to do in the backbranches other
> > than hide the pesky record to avoid it breaking the test.
> 
> Oh, I see. Let's just remove the first insertion then, as in attached.
> I've tested it on master and on 9.4.

Ah, okay.  Does the test still fail when run without the code fix?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Don't deform column-by-column in composite_to_json
Next
From: Tom Lane
Date:
Subject: Re: Don't deform column-by-column in composite_to_json