On Tue, Dec 25, 2018 at 11:45:09PM -0300, Alvaro Herrera wrote:
> Umm, this is established coding pattern in pg_basebackup.c.
> Stylistically I'd change all those cases to "fprintf(stderr,
> isatty(fileno(stderr)) ? "\r" : "\n")" but leave the string alone, since
> AFAIR it took some time to figure out what to do. (I'd also make the
> comment one line instead of four, say "Stay on the same line if
> reporting to a terminal". That makes the whole stanza two lines rather
> than eight, which is the appropriate amount of space for it).
There has been no input from the author for a couple of weeks now, so
I have marked the patch as returned with feedback.
--
Michael
