Postgres Pro
Downloads
Home   >   mailing lists

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance
Date
Msg-id 201902020231.rts4q3czbyfm@alvherre.pgsql
Whole thread Raw
In response to Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance  (Lætitia Avrot <laetitia.avrot@gmail.com>)
Responses Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance  (Lætitia Avrot <laetitia.avrot@gmail.com>)
List pgsql-hackers
Tree view 
On 2019-Jan-31, Lætitia Avrot wrote:

> Hi,
> 
> Thanks to Emil Iggland's kind review, I added precision on documentation
> for hyperbolic functions.

Hello

I see that in dtanh() you set errno to 0 before calling tanh(), but 1)
you don't check for it afterwards (seems like you should be checking for
ERANGE, as well as checking the return value for isinf()), and 2) you
don't do that in dsinh() and dcosh() and I'm not quite sure I see why.
What's up with that?

Thanks,

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Non-deterministic IndexTuple toast compression fromindex_form_tuple() + amcheck false positives
Next
From: Amit Kapila
Date:
Subject: Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IOFailure Occurs