Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date
Msg-id 20190201034236.GG2179@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Jan 31, 2019 at 11:19:11AM +0900, Michael Paquier wrote:
> Ah yes, good point about CFLAGS and LDFLAGS.  It would be better to
> add a comment about that and document the difference, aka "prepend" or
> "append" the flag values.
>
> CXXFLAGS applies to compiler options like -g -O2 which you would like
> to enforce for the C++ compiler, so it seems to me that like CFLAGS
> the custom values should be added at the end and not at the beginning,
> no?

Attached is a patch doing that.  Thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: WIP: Avoid creation of the free space map for small tables
Next
From: Michael Paquier
Date:
Subject: Re: pg_dumpall --exclude-database option