Re: Simplify set of flags used by MyXactFlags - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Simplify set of flags used by MyXactFlags
Date
Msg-id 201901241156.dckqy4zkclj4@alvherre.pgsql
Whole thread Raw
In response to Re: Simplify set of flags used by MyXactFlags  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Simplify set of flags used by MyXactFlags  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2019-Jan-22, Michael Paquier wrote:

> On Mon, Jan 21, 2019 at 02:58:39PM -0300, Alvaro Herrera wrote:
> > "... operated on temp namespace" doesn't look good; seems to me to be
> > missing an article, for one thing, but really I'm not sure that
> > 'namespace' is the term to be using here.  I'd say "... operated on
> > temporary objects" instead (the plural avoids the need for the article;
> > and the user doesn't really care about the namespace itself but rather
> > about the objects it contains.)
> 
> Thanks for the input.  Would you prefer something like the attached
> then?  I have switched the error message to "temporary objects", and
> renamed the flag to XACT_FLAGS_ACCESSEDTEMPOBJECTS.

Uh, I didn't think it was necessary nor desirable to rename the flag,
only the user-visible message.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Connection slots reserved for replication
Next
From: Alvaro Herrera
Date:
Subject: Re: using expression syntax for partition bounds