Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date
Msg-id 20190122201923.3iaz7lxs3ckibzwo@alap3.anarazel.de
Whole thread Raw
In response to Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hi,

On 2019-01-22 17:10:58 -0300, Alvaro Herrera wrote:
> On 2019-Jan-22, Andres Freund wrote:
> 
> > I think its plain wrong to add COPT to CXXFLAGS. Re PROFILE I'm on the
> > fence.  I personally think the pgxs stuff is a bit separate, and I'm
> > doubtful we ought to backpatch that.  I'm basically planning to apply
> > https://www.postgresql.org/message-id/20190107091734.GA1582%40msg.credativ.de
> > to 11-, minus the PGXS stuff. If we want that, we ought to apply it to
> > master only IMO.
> 
> I don't understand why you don't want to backpatch the PGXS bits.

Largely because I think it's an independent patch from the CXXOPT need
from Christopher / Debian packaging.  It's a larger patch, that needs
more docs etc.  If whoever applies that wants to backpatch it - I'm not
going to protest, I just wouldn't myself, unless somebody pipes up that
it'd help them.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Next
From: Kevin Grittner
Date:
Subject: Re: Refactoring the checkpointer's fsync request queue