Re: Simplify set of flags used by MyXactFlags - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Simplify set of flags used by MyXactFlags
Date
Msg-id 201901211758.aafj3aglm24t@alvherre.pgsql
Whole thread Raw
In response to Simplify set of flags used by MyXactFlags  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Simplify set of flags used by MyXactFlags  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2019-Jan-18, Michael Paquier wrote:

> Keeping both messages makes the error handling at PREPARE time perhaps
> a bit cleaner to make the difference about schema-level access or
> table-level access, still I'd rather simplify the code and just only
> keep the schema-level change as something we complain about.  Another
> thing is that ACCESSEDTEMPREL is used in PreCommit_on_commit_actions()
> to avoid the truncates of ON COMMIT DELETE ROWS if no temporary tables
> have been accessed, still it would just mean that truncation would be
> tried on empty tables for nothing even if say a function is created in
> pg_temp.

"... operated on temp namespace" doesn't look good; seems to me to be
missing an article, for one thing, but really I'm not sure that
'namespace' is the term to be using here.  I'd say "... operated on
temporary objects" instead (the plural avoids the need for the article;
and the user doesn't really care about the namespace itself but rather
about the objects it contains.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: Re: Thread-unsafe coding in ecpg
Next
From: Alvaro Herrera
Date:
Subject: Re: House style for DocBook documentation?