Re: Use atexit() in initdb and pg_basebackup - Mailing list pgsql-hackers

On 2019-Jan-05, Peter Eisentraut wrote:

> On 04/01/2019 20:35, Alvaro Herrera wrote:

> >> +    /* prevent cleanup */
> >> +    made_new_pgdata = found_existing_pgdata = made_new_xlogdir = found_existing_xlogdir = false;
> >> +
> >>      return 0;
> >>  }
> > 
> > This is a bit ugly, but meh.
> 
> Yeah.  Actually, we already have a solution of this in pg_basebackup,
> with a bool success variable.  I rewrote it like that.  At least it's
> better for uniformity.

Ah, yeah, much better, LGTM.

> I also added an atexit() conversion in isolationtester.  It's mostly the
> same thing.

LGTM in a quick eyeball.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services