Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date
Msg-id 20190104133305.GG2067@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
List pgsql-hackers
Tree view 
On Fri, Jan 04, 2019 at 11:41:15AM +0100, Peter Eisentraut wrote:
> Note that pgxs supports PG_CPPFLAGS for adding custom pieces to CPPFLAGS
> in a safe way.  Maybe we should add an equivalent for CFLAGS?  It's just
> that it hasn't been needed so far.

+1.  Wouldn't it make sense to also have PG_LDFLAGS?  In some stuff I
maintain, I have been abusing of PG_CPPFLAGS to pass some flags, which
is not really right.  We also have contrib/passwordcheck/Makefile
abuse of it to set -DUSE_CRACKLIB..
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Custom text type for title text
Next
From: Daniel Gustafsson
Date:
Subject: Re: Allow auto_explain to log to NOTICE