Re: Prepare Transaction support for ON COMMIT DROP temporary tables - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Prepare Transaction support for ON COMMIT DROP temporary tables
Date
Msg-id 20181228233230.GD2972@paquier.xyz
Whole thread Raw
In response to Re: Prepare Transaction support for ON COMMIT DROP temporary tables  (Dimitri Fontaine <dimitri@citusdata.com>)
Responses Re: Prepare Transaction support for ON COMMIT DROP temporary tables  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Dec 28, 2018 at 08:32:15PM +0100, Dimitri Fontaine wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> I suggest to add in your regression tests a case where the prepared
>> transaction commits, and ensuring that the temp table is gone from
>> catalogs.
>
> Please find such a revision attached.

Being able to relax a bit the case is better than nothing, so that's
nice to see incremental improvements.  Thanks Dimitri.

I just had a very quick glance, so that's far from being a detailed
review, but could it be possible to add test cases involving
inheritance trees and/or partitions if that makes sense?  The ON
COMMIT action handling is designed to make such cases work properly.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Making all nbtree entries unique by having heap TIDs participatein comparisons
Next
From: Tom Lane
Date:
Subject: Re: random() (was Re: New GUC to sample log queries)