Re: random() (was Re: New GUC to sample log queries) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: random() (was Re: New GUC to sample log queries)
Date
Msg-id 20181227020433.GH2106@paquier.xyz
Whole thread Raw
In response to Re: random() (was Re: New GUC to sample log queries)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Dec 26, 2018 at 08:46:25PM -0500, Tom Lane wrote:
> One thing I was wondering is if we should try to enforce a policy
> like this by putting, say,
>
> #define random() pg_random()
>
> into port.h or so.  That would have the advantages of not having to touch
> any existing calls and not having to worry too much about future patches
> breaking the policy.  On the other hand, it's conceivable that third-party
> extensions might get annoyed with us for hijacking a libc function.
> Thoughts?

Not much a fan of that for random() to be honest as we are talking
about 15 callers in the backend code and enforcing a call of in a
low-level library..
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: GIN predicate locking slows down valgrind isolationtests tremendously
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Fix failure to check for open() or fsync() failures.