Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix failure to check for open() or fsync() failures. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: Fix failure to check for open() or fsync() failures.
Date
Msg-id 20181227010918.GC2106@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Fix failure to check for open() or fsync() failures.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix failure to check for open() or fsync() failures.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Wed, Dec 26, 2018 at 05:55:36PM -0500, Tom Lane wrote:
> It appears to me that the code is intentionally not worrying about
> fsync failure, so it seems wrong for it to FATAL out if it's unable
> to open the file to fsync it.  And it surely shouldn't do so if the
> file isn't there.

My point is a bit different though: it seems to me that we could just
call BasicOpenFilePerm() and remove the stat() to do exactly the same
things, simplifying the code.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: removal of dangling temp tables
Next
From: Michael Paquier
Date:
Subject: Re: Offline enabling/disabling of data checksums