Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve tab completion for CREATE TABLE - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Improve tab completion for CREATE TABLE
Date
Msg-id 20181219234408.GD27104@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Improve tab completion for CREATE TABLE  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: [PATCH] Improve tab completion for CREATE TABLE
List pgsql-hackers
Tree view 
On Wed, Dec 19, 2018 at 11:22:29PM +0000, Dagfinn Ilmari Mannsåker wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> +   /* Complete ON COMMIT actions for temp tables */
>> +   else if (TailMatches("ON", "COMMIT"))
>> +       COMPLETE_WITH("PRESERVE ROWS", "DELETE ROWS", "DROP");
>>
>> This causes ON COMMIT to show up for permanent and unlogged tables.
>
> No, this is for completing _after_ ON COMMIT, which is only suggested by
> the clause for temporary tables above.

If a user types "CREATE TABLE foo () ON COMMIT" by himself and then asks
for tab completion then he would get the suggestion, which is incorrect?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: A tidbit I spotted while playing in tablecmds.c
Next
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Subject: Re: [PATCH] Improve tab completion for CREATE TABLE