Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements
Date
Msg-id 20181219054529.GE19856@paquier.xyz
Whole thread Raw
In response to Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
On Sun, Dec 16, 2018 at 10:33:38AM +0100, Pavel Stehule wrote:
> Now, the statement's hook is not called for every plpgsql_stmt_block
> statement. It is not big issue, but it is not consistent - and this
> inconsistency should be repaired inside extension. Better to be consistent
> and every plpgsql statement call identically.
>
> patch attached - all regress tests passed. This patch has a effect only on
> plpgsql extensions.

I can see the inconsistency in the code, still do you have a simple
plpgsql extension where it is possible to see the difference in
behavior?  This involves execution of functions, triggers and event
triggers, and exec_stmt_block is used since the beginning of times.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Next
From: Pavel Stehule
Date:
Subject: Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements