Re: Fixing typos in tests of partition_info.sql - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fixing typos in tests of partition_info.sql
Date
Msg-id 20181217104942.GA2501@paquier.xyz
Whole thread Raw
In response to Re: Fixing typos in tests of partition_info.sql  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: Fixing typos in tests of partition_info.sql  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Dec 17, 2018 at 06:35:03PM +0900, Amit Langote wrote:
> As far as the information content of this comment is concerned, I think
> it'd be more useful to word this comment such that it is applicable to
> different functions than to word it such that it is applicable to
> different queries.  More opinions would be nice.

This argument is sensible.

> Okay, how about:
>
> -- Various partitioning-related functions return NULL if passed relations
> -- of types that cannot be part of a partition tree; for example, views,
> -- materialized views, etc.

Okay, this suggestion sounds fine to me.  Thanks!
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Surafel Temesgen
Date:
Subject: Re: pg_dump multi VALUES INSERT
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: New function pg_stat_statements_reset_query() to resetstatistics of a specific query