Re: Fixing typos in tests of partition_info.sql - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fixing typos in tests of partition_info.sql
Date
Msg-id 20181217073823.GD5223@paquier.xyz
Whole thread Raw
In response to Re: Fixing typos in tests of partition_info.sql  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: Fixing typos in tests of partition_info.sql  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Dec 17, 2018 at 04:14:07PM +0900, Amit Langote wrote:
> --- A table not part of a partition tree works is the only member listed.
> +-- A table not part of a partition tree is the only member listed.
>
> How about:
>
> -- Table that is not part of any partition tree is the only member listed
>
> --- Views and materialized viewS cannot be part of a partition tree.
> +-- Views and materialized views are not part of a partition tree,
> +-- causing the functions to return NULL.
>
> How about:
>
> -- Functions returns NULL for relation types that cannot be part of a
> -- partition tree; for example, views, materialized views, etc.

Your two suggestions look fine to me, so let's just reuse your wording.
i would just use the plural for the last comment with "Functions return"
as pg_partition_tree gets called multiple times, and later on
pg_partition_root will likely be added.

Perhaps there are other suggestions?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: ALTER INDEX ... ALTER COLUMN not present in dump
Next
From: Amit Langote
Date:
Subject: Re: Fixing typos in tests of partition_info.sql