Re: automatically assigning catalog toast oids - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: automatically assigning catalog toast oids
Date
Msg-id 20181209204257.GH3415@tamriel.snowman.net
Whole thread Raw
In response to Re: automatically assigning catalog toast oids  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: automatically assigning catalog toast oids  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> John Naylor <jcnaylor@gmail.com> writes:
> > Commit 96cdeae07 added toast tables to most catalogs. One disadvantage
> > is that the toast declarations require hard-coded oids, even though
> > only shared catalogs actually need stable oids. Now that we can assign
> > oids on the fly, it makes sense to do so for toast tables as well, as
> > in the attached.
>
> I'm a bit dubious that this is a good idea.  It's handy, at least for
> forensic situations, that the system catalogs have stable OIDs.

I tend to agree...  What's the advantage of assigning them on the fly?

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Why does TupleDescInitBuiltinEntry lack a "default: error" case?
Next
From: Andres Freund
Date:
Subject: Re: automatically assigning catalog toast oids