Re: Hint and detail punctuation - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Hint and detail punctuation
Date
Msg-id 20181206044626.GG2407@paquier.xyz
Whole thread Raw
In response to Hint and detail punctuation  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Hint and detail punctuation  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Wed, Dec 05, 2018 at 05:22:25PM +0100, Daniel Gustafsson wrote:
> While looking at error messages downstream, I noticed a few hints and details
> in postgres which aren’t punctuated as per the style guide.  The attached patch
> fixes the ones where it seemed reasonable to end with a period.

Good point.  I am spotting a couple more places:
src/backend/utils/misc/guc.c:
GUC_check_errdetail("effective_io_concurrency must be set to 0 on
platforms that lack posix_fadvise()");
src/backend/utils/misc/guc.c:
GUC_check_errdetail("recovery_target_timeline is not a valid number");
src/backend/utils/misc/guc.c:
GUC_check_errdetail("recovery_target_name is too long (maximum %d
characters)",

Thanks,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: zheap: a new storage format for PostgreSQL
Next
From: Amit Langote
Date:
Subject: Re: error message when subscription target is a partitioned table