Re: pgsql: Avoid duplicate XIDs at recovery when building initialsnapshot - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: Avoid duplicate XIDs at recovery when building initialsnapshot
Date
Msg-id 20181203064358.GI3423@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-hackers
On Sat, Dec 01, 2018 at 10:51:10AM +0000, Simon Riggs wrote:
> On Fri, 30 Nov 2018 at 23:08, Michael Paquier <michael@paquier.xyz> wrote:
>> It is not complicated to
>> handle duplicates for xacts and subxacts however holding ProcArrayLock
>> for a longer time stresses me as it is already a bottleneck.
>
> I hadn't realised this patch holds ProcArrayLock while removing duplicates.
> Now I know I vote against applying this patch unless someone can show that
> the performance effects of doing so are negligable, which I doubt.

Me too after more thoughts on that.  Please note that I have marked the
patch as returned with feedback for now.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: error message when subscription target is a partitioned table
Next
From: rajan
Date:
Subject: Re: vacuum and autovacuum - is it good to configure the thresholdat TABLE LEVEL?