Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Change "checkpoint starting" message to use "wal" - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Change "checkpoint starting" message to use "wal"
Date
Msg-id 20181130011642.GA2267@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Change "checkpoint starting" message to use "wal"  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Tree view 
On Thu, Nov 29, 2018 at 07:31:02PM -0500, Stephen Frost wrote:
> * Tsunakawa, Takayuki (tsunakawa.takay@jp.fujitsu.com) wrote:
>> From: Christoph Berg [mailto:christoph.berg@credativ.de]
>> > A customer was complaining that the "checkpoint starting: xlog"
>> > message was not included in the grand PG10 rename of user-visible bits.
>> > The attached patch fixes that.
>>
>> Can we make use of this chance to change elog() to ereport(), so that the two messages are translated?
>
> +1, and we should probably look for nearby cases to fix also..

Good point.  +1.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager
Next
From: Michael Paquier
Date:
Subject: Re: More issues with pg_verify_checksums and checksum verificationin base backups