Re: pg_stat_ssl additions - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_stat_ssl additions
Date
Msg-id 20181128173454.GF24817@momjian.us
Whole thread Raw
In response to Re: pg_stat_ssl additions  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: pg_stat_ssl additions
Re: pg_stat_ssl additions
List pgsql-hackers
On Wed, Nov 28, 2018 at 06:31:59PM +0100, Peter Eisentraut wrote:
> On 20/11/2018 22:41, Peter Eisentraut wrote:
> >>> - Adds new fields to pg_stat_ssl: issuerdn and clientserial.  These
> >>> allow uniquely identifying the client certificate.  AFAICT, these are
> >>> the most interesting pieces of information provided by sslinfo but not
> >>> in pg_stat_ssl.  (I don't like the underscore-free naming of these
> >>> fields, but it matches the existing "clientdn".)
> >> clientdn, clientserial, issuerdn are the fields about client
> >> certificates. Only the last one omits prefixing "client". But
> >> "clientissuerdn" seems somewhat rotten... Counldn't we rename
> >> clientdn to client_dn?
> > I'd prefer renaming as well, but some people might not like that.
> 
> Any thoughts from others about whether to rename clientdn to client_dn
> to allow better naming of the new fields?

Makes sense.  The SSL acronyms can get very complex.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: More issues with pg_verify_checksums and checksum verification inbase backups
Next
From: Stephen Frost
Date:
Subject: Re: pg_stat_ssl additions