Re: typo fix - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: typo fix
Date
Msg-id 20181120071556.GL4400@paquier.xyz
Whole thread Raw
In response to Re: typo fix  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Nov 20, 2018 at 01:58:22AM -0500, Tom Lane wrote:
> The reason that's not good is that it creates a singular-plural mismatch.
> If you'd also changed "PathKeys" to "PathKey", it would still read OK,
> though I don't think it's an improvement particularly.
>
> (Hm ... though arguably, "structure" should be "structures" if we're
> going to let it stand as plural.)

Indeed, missed that.  This first sentence mentions "orderings" for those
PathKeys, which refers to multiple PathKeys, so actually Amit's patch
seems to be fine, no?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: typo fix
Next
From: Haozhou Wang
Date:
Subject: Re: Control your disk usage in PG: Introduction to Disk Quota Extension