Re: ATTACH/DETACH PARTITION CONCURRENTLY - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: ATTACH/DETACH PARTITION CONCURRENTLY
Date
Msg-id 20181115053830.GC1374@paquier.xyz
Whole thread Raw
In response to Re: ATTACH/DETACH PARTITION CONCURRENTLY  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: ATTACH/DETACH PARTITION CONCURRENTLY
Re: ATTACH/DETACH PARTITION CONCURRENTLY
List pgsql-hackers
On Thu, Nov 15, 2018 at 01:38:55PM +0900, Amit Langote wrote:
> I've fixed 0001 again to re-order the code so that allocations happen the
> correct context and now tests pass with the rebased patches.

I have been looking at 0001, and it seems to me that you make even more
messy the current situation.  Coming to my point: do we have actually
any need to set rel->rd_pdcxt and rel->rd_partdesc at all if a relation
has no partitions?  It seems to me that we had better set rd_pdcxt and
rd_partdesc to NULL in this case.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Synchronous replay take III
Next
From: Laurenz Albe
Date:
Subject: Re: reloption to prevent VACUUM from truncating empty pages at theend of relation