Re: Large writable variables - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Large writable variables
Date
Msg-id 20181015215756.pdhi2hqxofphvcxe@alap3.anarazel.de
Whole thread Raw
In response to Re: Large writable variables  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: Large writable variables  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
On 2018-10-16 10:16:34 +1300, Thomas Munro wrote:
> On Tue, Oct 16, 2018 at 9:07 AM Andres Freund <andres@anarazel.de> wrote:
> > $ nm -t d --size-sort -r -S src/backend/postgres|grep '\b[bB]\b'|head
> > 0000000008251872 0000000000131144 b LagTracker
> ...
> > So we have a two variables sized 130kb. Yikes.
> ...
> > that's not actually used very often, nor in all processes... Thomas?
> 
> Yeah, here's a patch to move it in to the heap.
> 
> -- 
> Thomas Munro
> http://www.enterprisedb.com

> From f3fb64e67c1e86e11dfafc8a712e9750f650f60b Mon Sep 17 00:00:00 2001
> From: Thomas Munro <thomas.munro@enterprisedb.com>
> Date: Tue, 16 Oct 2018 10:08:57 +1300
> Subject: [PATCH] Move the replication lag tracker into heap memory.
> 
> Andres Freund complained about the 128KB of .bss occupied by LagTracker.
> It's only needed in the walsender process, so allocate it in heap
> memory there.

Cool, let's do that.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: "Jonathan S. Katz"
Date:
Subject: Re: PostgreSQL 11 RC1 + GA Dates
Next
From: Thomas Munro
Date:
Subject: Re: Large writable variables