Re: pg_upgrade failed with ERROR: null relpartbound for relation18159 error. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_upgrade failed with ERROR: null relpartbound for relation18159 error.
Date
Msg-id 20181007011532.5mhrode2b6gdsgue@alvherre.pgsql
Whole thread Raw
In response to Re: pg_upgrade failed with ERROR: null relpartbound for relation18159 error.  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: pg_upgrade failed with ERROR: null relpartbound for relation18159 error.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2018-Oct-05, Amit Langote wrote:

> On 2018/10/05 16:05, Michael Paquier wrote:
> >> As of commit 2fbdf1b38bc [1], which has been applied in 11 and HEAD
> >> branches, RelationBuildPartitionDesc emits an error if we don't find
> >> relpartbound set for a child found by scanning pg_inherits, instead of
> >> skipping such children.  While that commit switched the order of creating
> >> pg_inherits entry and checking a new bound against existing bounds in
> >> DefineRelation in light of aforementioned change, it didn't in
> >> ATExecAttachPartition, hence this error.
> >>
> >> Attached patch fixes that.
> > 
> > Could you please add a minimal regression test in your patch?  That's
> > the second bug related to ATTACH PARTITION I am looking at today..
> 
> OK, done, although I hope that's not bloating the tests.

Pushed to 11 and master.  I'm not convinced that it's a good idea to
mess with 10 at this point -- the partitioning code is rather completely
different already ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Segfault when creating partition with a primary key and sql_droptrigger exists
Next
From: Thomas Munro
Date:
Subject: Re: Relax transactional restrictions on ALTER ENUM ... ADD TYPE (redux)