Re: Segfault when creating partition with a primary key and sql_droptrigger exists - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Segfault when creating partition with a primary key and sql_droptrigger exists
Date
Msg-id 20181005235454.GA1197@paquier.xyz
Whole thread Raw
In response to Re: Segfault when creating partition with a primary key and sql_drop trigger exists  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Segfault when creating partition with a primary key and sql_droptrigger exists  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Fri, Oct 05, 2018 at 04:04:02PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> On 2018-Oct-04, Tom Lane wrote:
>>> Not sure about that.  Alvaro seems to think there's a generic problem
>>> in event trigger processing, which if true, was likely there pre-v11.
>
>> After sleeping on this, I think that a better answer is to fix the crash
>> per Michael's proposed patch, and fix the rest of the deparse problem
>> later.
>
> Well, let's push it sooner not later, so we can get buildfarm coverage
> before RC1.

I have to admit that I am not confident enough to commit this patch
myself yet as I would need to spend a couple of extra hours on it and
looking at the event triggers generated for other event types, and there
is a three-day weekend waiting ahead in Japan.  Could any of you take
care of it?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: Early WIP/PoC for inlining CTEs
Next
From: Michael Paquier
Date:
Subject: Re: Assertion failure with ALTER TABLE ATTACH PARTITION withlog_min_messages >= DEBUG1