Re: Problem while setting the fpw with SIGHUP - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Problem while setting the fpw with SIGHUP
Date
Msg-id 20180927080221.GU1659@paquier.xyz
Whole thread Raw
In response to Re: Problem while setting the fpw with SIGHUP  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Problem while setting the fpw with SIGHUP  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Thu, Sep 27, 2018 at 11:18:02AM +0530, Amit Kapila wrote:
> Your proposed solution makes sense to me.  IIUC, this is quite similar
> to what Dilip has also proposed [1].

Indeed.  I would just add with the patch a comment like that:
"Perform this call outside the critical section so as if the instance
just got out of recovery, the upcoming WAL insert initialization does
not trigger an assertion failure."

If that sounds fine to you, I propose that we commit Dilip's patch with
the comment addition.  That will take care of (a).
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Problem while setting the fpw with SIGHUP
Next
From: Александр Аникин
Date:
Subject: Create roles trigger